64b2ff0 | only-bible-app

git clone https://git.pyrossh.dev/only-bible-app

The only bible app you will ever need. No ads. No in-app purchases. No distractions.

64b2ff0 — Peter John 2026-08-09T15:29:41+05:30

more improved testing

Files changed (3) hide show

test/app_logic_test.dart +12 -37
test/navigation_integration_test.dart +135 -0
test/verse_selection_integration_test.dart +65 -0

test/app_logic_test.dart CHANGED Viewed

@@ -340,22 +340,10 @@ void main() {
     });
   });
-  group("RemoveHighlightAction", () {
-    test("removes the highlight and clears the selection", () async {
+  // RemoveHighlightAction's "removes the highlight and clears the selection"
-      final bible = buildTestBible();
-      final verse = bible.bookAt(0)!.chapterAt(0)!.verseAt(0)!;
-      final store = Store<AppState>(
-        initialState: AppState(
-          bible: bible,
-          highlights: {"0:0:0": 1},
-          selectedVerses: [verse],
-        ),
-      );
-      await store.dispatchAndWait(RemoveHighlightAction([verse]));
+  // behavior is covered by test/verse_selection_integration_test.dart, which
-      expect(store.state.highlights.containsKey("0:0:0"), isFalse);
+  // exercises it (and the tap -> action wiring around it) through real UI
-      expect(store.state.selectedVerses, isEmpty);
+  // interaction rather than a bare dispatch.
-    });
-  });
   group("adjacentChapter", () {
     test("moves to the next chapter within the same book", () {
@@ -389,20 +377,17 @@ void main() {
     });
   });
-  group("UpdateChapterAction", () {
-    test("updates savedBook/savedChapter", () async {
+  // UpdateChapterAction is a trivial 2-line reducer, and its effect is
-      final bible = buildTestBible();
+  // already exercised end-to-end by the GoToChapterAction/NextChapterAction/
-      final store = Store<AppState>(
+  // etc. integration tests below - a standalone dispatch-and-assert test for
-        initialState: AppState(bible: bible, savedBook: 0, savedChapter: 0),
+  // it added no signal beyond what those already cover.
-      );
-      await store.dispatchAndWait(UpdateChapterAction(1, 0));
-      expect(store.state.savedBook, 1);
-      expect(store.state.savedChapter, 0);
-    });
-  });
   group("SyncCurrentChapterAction", () {
     test("is a no-op when book/chapter already match", () async {
+      // Unlike the "updates state when they differ" half of this reducer -
+      // now covered end-to-end by the integration tests below - this checks
+      // object identity is preserved (avoids an unnecessary rebuild), which
+      // isn't something a UI-driven test can observe.
       final bible = buildTestBible();
       final store = Store<AppState>(
         initialState: AppState(bible: bible, savedBook: 1, savedChapter: 0),
@@ -411,16 +396,6 @@ void main() {
       await store.dispatchAndWait(SyncCurrentChapterAction(1, 0));
       expect(identical(store.state, stateBefore), isTrue);
     });
-    test("updates state when book/chapter differ", () async {
-      final bible = buildTestBible();
-      final store = Store<AppState>(
-        initialState: AppState(bible: bible, savedBook: 0, savedChapter: 0),
-      );
-      await store.dispatchAndWait(SyncCurrentChapterAction(1, 0));
-      expect(store.state.savedBook, 1);
-      expect(store.state.savedChapter, 0);
-    });
   });
   // These used to be untestable here: they all call stopAudioPlayback(),

test/navigation_integration_test.dart ADDED Viewed

@@ -0,0 +1,135 @@
+// Integration-style tests: these mount the real App widget and drive it
+// through actual taps (find + tap real keys/text), rather than dispatching
+// actions programmatically against a bare store/router. That distinction
+// matters: an earlier bug (App._syncCurrentChapter clobbering
+// savedBook/savedChapter right after a push()) went unnoticed by unit tests
+// that dispatched actions directly, because they never mounted the widget
+// tree that wires the router's listener up in the first place. Driving the
+// same flows through the UI is what actually would have caught it.
+import "package:flutter/material.dart";
+import "package:flutter_test/flutter_test.dart";
+import "package:async_redux/async_redux.dart";
+import "package:only_bible_app/app.dart";
+import "package:only_bible_app/store/app_state.dart";
+import "package:only_bible_app/widgets/book_select_sheet.dart";
+import "package:only_bible_app/widgets/book_tile.dart";
+import "app_logic_test.dart" show buildTestBible;
+/// Taps the [label] tile inside whichever [BookSelectSheet] is currently on
+/// screen - scoped there (rather than a bare find.text(label)) because plain
+/// text like a chapter number ("1", "2") can otherwise collide with the
+/// current-chapter number shown in the app bar behind the sheet.
+Future<void> tapSheetTile(WidgetTester tester, String label) async {
+  final sheet = find.byType(BookSelectSheet);
+  await tester.tap(find.descendant(of: sheet, matching: find.text(label)));
+  await tester.pumpAndSettle();
+}
+bool _isSelectedTile(Widget w, String label) =>
+    w is BookTile && w.label == label && w.isSelected;
+void main() {
+  TestWidgetsFlutterBinding.ensureInitialized();
+  testWidgets(
+    "navigating via the book+chapter selector updates the displayed chapter, and "
+    "reopening the selector highlights that new book/chapter - not the one "
+    "navigated away from (regression: App._syncCurrentChapter used to clobber "
+    "savedBook/savedChapter right after the push, so the selector kept "
+    "highlighting the pre-navigation position)",
+    (tester) async {
+      final bible = buildTestBible();
+      final store = Store<AppState>(
+        initialState: AppState(bible: bible, savedBook: 0, savedChapter: 0),
+      );
+      await tester.pumpWidget(
+        App(globalNavigatorKey: GlobalKey<NavigatorState>(), store: store),
+      );
+      await tester.pumpAndSettle();
+      // Sanity check: Genesis 1 is on screen to start with. Verse text
+      // renders as rich text with a "1 " verse-number span prefixed, so this
+      // is a substring match rather than find.text's exact match.
+      expect(find.textContaining("In the beginning..."), findsOneWidget);
+      // Open the book selector via the app bar's book title.
+      await tester.tap(find.byKey(const Key("bookTitle")));
+      await tester.pumpAndSettle();
+      // Pick Revelation (a multi-chapter book, so this animates to the
+      // chapter grid rather than closing immediately).
+      await tapSheetTile(tester, "Rev");
+      // Pick chapter 2.
+      await tapSheetTile(tester, "2");
+      // The displayed chapter should now be Revelation 2.
+      expect(find.textContaining("Rev 2:1"), findsOneWidget);
+      expect(store.state.savedBook, 2);
+      expect(store.state.savedChapter, 1);
+      // Reopen the book selector - this is the exact regression.
+      await tester.tap(find.byKey(const Key("bookTitle")));
+      await tester.pumpAndSettle();
+      final sheet = find.byType(BookSelectSheet);
+      expect(
+        find.descendant(
+          of: sheet,
+          matching: find.byWidgetPredicate((w) => _isSelectedTile(w, "Rev")),
+        ),
+        findsOneWidget,
+      );
+      expect(
+        find.descendant(
+          of: sheet,
+          matching: find.byWidgetPredicate((w) => _isSelectedTile(w, "Gen")),
+        ),
+        findsNothing,
+      );
+    },
+  );
+  testWidgets(
+    "swiping to the next chapter after using the picker keeps the app bar's chapter number in sync",
+    (tester) async {
+      final bible = buildTestBible();
+      final store = Store<AppState>(
+        initialState: AppState(bible: bible, savedBook: 0, savedChapter: 0),
+      );
+      await tester.pumpWidget(
+        App(globalNavigatorKey: GlobalKey<NavigatorState>(), store: store),
+      );
+      await tester.pumpAndSettle();
+      // Jump to Revelation 1 via the picker (push).
+      await tester.tap(find.byKey(const Key("bookTitle")));
+      await tester.pumpAndSettle();
+      await tapSheetTile(tester, "Rev");
+      await tapSheetTile(tester, "1");
+      expect(find.textContaining("Rev 1:1"), findsOneWidget);
+      // Swipe left to advance to chapter 2 (pushReplacement on top of the
+      // still-2-entry stack the picker's push left behind).
+      await tester.fling(
+        find.byType(SingleChildScrollView),
+        const Offset(-400, 0),
+        800,
+      );
+      await tester.pumpAndSettle();
+      expect(find.textContaining("Rev 2:1"), findsOneWidget);
+      expect(store.state.savedBook, 2);
+      expect(store.state.savedChapter, 1);
+      // The app bar's chapter number (built from the same live state) must
+      // agree with what's actually on screen.
+      expect(
+        find.descendant(
+          of: find.byKey(const Key("chapterTitle")),
+          matching: find.text("2"),
+        ),
+        findsOneWidget,
+      );
+    },
+  );
+}

test/verse_selection_integration_test.dart ADDED Viewed

@@ -0,0 +1,65 @@
+// Integration-style tests driving verse selection and highlighting through
+// real taps on the rendered Home screen and MenuOverlay, rather than
+// dispatching SelectVerseAction/SetHighlightAction/RemoveHighlightAction
+// directly against a bare store. Tapping through the actual widgets is what
+// verifies the UI wiring (GestureDetector -> action, MenuOverlay appearing
+// only while verses are selected, etc.) alongside the reducer logic itself.
+import "package:flutter/material.dart";
+import "package:flutter_test/flutter_test.dart";
+import "package:async_redux/async_redux.dart";
+import "package:only_bible_app/app.dart";
+import "package:only_bible_app/store/app_state.dart";
+import "package:only_bible_app/widgets/highlight_button.dart";
+import "package:only_bible_app/widgets/menu_overlay.dart";
+import "app_logic_test.dart" show buildTestBible;
+void main() {
+  TestWidgetsFlutterBinding.ensureInitialized();
+  testWidgets(
+    "tapping a verse selects it and shows the menu overlay; tapping a highlight color "
+    "applies it and clears the selection; tapping remove clears the highlight",
+    (tester) async {
+      final bible = buildTestBible();
+      final store = Store<AppState>(
+        initialState: AppState(bible: bible, savedBook: 0, savedChapter: 0),
+      );
+      await tester.pumpWidget(
+        App(globalNavigatorKey: GlobalKey<NavigatorState>(), store: store),
+      );
+      await tester.pumpAndSettle();
+      // No selection yet - the overlay shouldn't be showing.
+      expect(find.byType(MenuOverlay), findsNothing);
+      // Tap the first verse ("In the beginning...") to select it.
+      await tester.tap(find.textContaining("In the beginning..."));
+      await tester.pumpAndSettle();
+      expect(store.state.selectedVerses, hasLength(1));
+      expect(store.state.selectedVerses.single.index, 0);
+      expect(find.byType(MenuOverlay), findsOneWidget);
+      // Tap the first highlight color in the now-visible overlay.
+      await tester.tap(find.byType(HighlightButton).first);
+      await tester.pumpAndSettle();
+      expect(store.state.highlights["0:0:0"], 0);
+      // Applying a highlight clears the selection, so the overlay goes away.
+      expect(store.state.selectedVerses, isEmpty);
+      expect(find.byType(MenuOverlay), findsNothing);
+      // Select the now-highlighted verse again and remove its highlight.
+      await tester.tap(find.textContaining("In the beginning..."));
+      await tester.pumpAndSettle();
+      expect(find.byType(MenuOverlay), findsOneWidget);
+      await tester.tap(find.byIcon(Icons.cancel_outlined));
+      await tester.pumpAndSettle();
+      expect(store.state.highlights.containsKey("0:0:0"), isFalse);
+      expect(store.state.selectedVerses, isEmpty);
+      expect(find.byType(MenuOverlay), findsNothing);
+    },
+  );
+}

only-bible-app v3.7.2+24

git clone https://git.pyrossh.dev/only-bible-app

The only bible app you will ever need. No ads. No in-app purchases. No distractions.